Merge pull request #34 from red0124/improvement/getline_update

Fix reallocation issues with non-POSIX get_line
2025-06-08 13:12:32 +02:00 · 2024-02-23 23:04:19 +01:00 · 2024-02-23 21:56:44 +01:00
2 changed files with 4 additions and 4 deletions
--- a/include/ss/common.hpp
+++ b/include/ss/common.hpp
@ -62,10 +62,10 @@ ssize_t get_line(char** lineptr, size_t* n, FILE* fp) {
        size_t line_used = strlen(*lineptr);
        size_t buff_used = strlen(buff);
-        if (*n < buff_used + line_used) {
+        if (*n <= buff_used + line_used) {
            size_t new_n = *n * 2;
-            auto new_lineptr = static_cast<char*>(realloc(*lineptr, *n));
+            auto new_lineptr = static_cast<char*>(realloc(*lineptr, new_n));
            if (new_lineptr == nullptr) {
                errno = ENOMEM;
                return -1;
--- a/ssp.hpp
+++ b/ssp.hpp
@ -674,10 +674,10 @@ ssize_t get_line(char** lineptr, size_t* n, FILE* fp) {
        size_t line_used = strlen(*lineptr);
        size_t buff_used = strlen(buff);
-        if (*n < buff_used + line_used) {
+        if (*n <= buff_used + line_used) {
            size_t new_n = *n * 2;
-            auto new_lineptr = static_cast<char*>(realloc(*lineptr, *n));
+            auto new_lineptr = static_cast<char*>(realloc(*lineptr, new_n));
            if (new_lineptr == nullptr) {
                errno = ENOMEM;
                return -1;
Author	SHA1	Message	Date
red0124	a27fd121a1	Merge pull request #34 from red0124/improvement/getline_update Fix reallocation issues with non-POSIX get_line	2024-02-23 23:04:19 +01:00
ado	c0d3087f85	Fix reallocation issues with non-POSIX get_line	2024-02-23 21:56:44 +01:00